Skip to content

Apply scalaFmt #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

Apply scalaFmt #5415

merged 1 commit into from
May 20, 2023

Conversation

style95
Copy link
Member

@style95 style95 commented May 19, 2023

Description

I am not quite sure when this regression is introduced and why our CI could not catch it in the first place, but anyway, codes are wrongly formatted.
This change just applies one from scalaFmt.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95 style95 requested a review from bdoyle0182 May 19, 2023 23:42
@bdoyle0182
Copy link
Contributor

This seems like it's from my two most recent PR's but I'm not sure why it wouldn't have been detected on build or if I had applied the wrong scalafmt?

@style95
Copy link
Member Author

style95 commented May 19, 2023

But I also think it should be caught by CI tests.
Our CI checks that.
https://github.com/apache/openwhisk/blob/master/tools/github/scan.sh#L41

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023 •
edited
Loading

Codecov Report

Merging #5415 (632ed73) into master (72bb2a1) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

❗ Current head 632ed73 differs from pull request most recent head cec7c3f. Consider uploading reports for the commit cec7c3f to get more accurate results

@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
- Coverage   76.83%   76.75%   -0.09%     
==========================================
  Files         241      241              
  Lines       14630    14630              
  Branches      616      616              
==========================================
- Hits        11241    11229      -12     
- Misses       3389     3401      +12
Impacted Files Coverage Δ
...enwhisk/core/entity/InstanceConcurrencyLimit.scala 75.00% <ø> (ø)
.../openwhisk/core/entity/IntraConcurrencyLimit.scala 90.32% <ø> (ø)
...che/openwhisk/core/loadBalancer/LeanBalancer.scala 0.00% <0.00%> (ø)
...pache/openwhisk/core/invoker/InvokerReactive.scala 71.53% <ø> (ø)
.../org/apache/openwhisk/core/controller/Limits.scala 91.30% <100.00%> (ø)
...la/org/apache/openwhisk/core/invoker/Invoker.scala 72.15% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95 style95 merged commit ba871e5 into apache:master May 20, 2023
@dgrove-oss dgrove-oss mentioned this pull request May 22, 2023
Closed
mtt-merz pushed a commit to mtt-merz/openwhisk that referenced this pull request Oct 22, 2023
@style95 @mtt-merz
Apply scalaFmt (apache#5415)
60cfcc9 
(cherry picked from commit ba871e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdoyle0182 bdoyle0182 bdoyle0182 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@style95 @bdoyle0182 @codecov-commenter